Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] - Crash when session is restored on Cr117 #32840

Closed
Brandon-T opened this issue Sep 7, 2023 · 0 comments · Fixed by brave/brave-core#20047
Closed

[iOS] - Crash when session is restored on Cr117 #32840

Brandon-T opened this issue Sep 7, 2023 · 0 comments · Fixed by brave/brave-core#20047
Assignees
Labels
bug crash OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude

Comments

@Brandon-T
Copy link

Description

  • Chromium is restoring every session to WebState and creating internal WebViews which don't apply to Brave-iOS
  • This causes a crash because they're expecting the restoration URL to be about:blank but iOS has already restored its webView and the URL can be wikipedia URL. So when we set the URL for History Sync, it will crash as they're different.

Steps to reproduce

  1. Open Wikipedia
  2. Close the app
  3. Re-open the app

Actual result

  • Crash

Expected result

  • No Crash

Issue reproduces how often

  • Easily reproduced

Version/Channel Information:

Chromium 117

Device details

  • Any iOS device

Brave version

  • 117.0.5938.48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug crash OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants