[iOS] - Fix #32840: Disable Chromium Session-Restore for WebState and WebViews #20047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brandon-T
added
CI/skip-android
soner-yuksel
approved these changes
Sep 7, 2023
25 tasks
StephenHeaps
approved these changes
Sep 7, 2023
Brandon-T
force-pushed
the
bugfix/ChromiumSessionRestore-iOS
branch
from
dfae8d5 to
3692389
Compare
mkarolin
added a commit
that referenced
this pull request
Sep 7, 2023
[iOS] - Fix #32840: Disable Chromium Session-Restore for WebState and WebViews
25 tasks
7 tasks
brave-builds
added a commit
that referenced
this pull request
Sep 7, 2023
kjozwiak
pushed a commit
that referenced
this pull request
Sep 11, 2023
* Merge pull request #19398 from brave/cr117 Upgrade from Chromium 116 to Chromium 117 * Explicitly adding rust sources to BUILD.gn files. This was done in the original cr117 PR, but this change is specific to 1.58.x branch rust sources. Chromium change: https://chromium.googlesource.com/chromium/src/+/eed02145256f53a0e85ffbb5bac4d567b625862a commit eed02145256f53a0e85ffbb5bac4d567b625862a Author: danakj <[email protected]> Date: Wed Jul 19 14:59:28 2023 +0000 List all inputs to rust targets in GN and verify them during build RBE requires all inputs to be named in order for it to copy them to the remote build environment. GN analyze requires all inputs to be named in order to decide what needs to be rebuilt based on a list of modified files. The current GN analyze setup was supposed to do this as well, but it is not working. Have gnrt produce a list of all (possible) input files for 3p and stdlib crates so that it can be included in the generated BUILD.gn files. Then verify in rustc_wrapper.py that all inputs rustc reports are found in the GN rule's sources or inputs fields by comparing with the depfile produced from rustc. Bug: 1459444 * Merge pull request #20022 from brave/ios-cr117-build-fix [iOS] Remove breaking `enable_arc` build configs * Merge pull request #20029 from brave/cargo-audit-0.18.1 Update cargo-audit to v0.18.1 * IWYU fix. * Upgrade from Chromium 117.0.5938.35 to Chromium 117.0.5938.48. (#20030) * Upgrade from Chromium 117.0.5938.35 to Chromium 117.0.5938.48 * Upgrade patches from Chromium 117.0.5938.35 to Chromium 117.0.5938.48 * Update pins list timestamp * Updated strings for Chromium 117.0.5938.48 --------- Co-authored-by: brave-builds <[email protected]> * Merge pull request #20047 from brave/bugfix/ChromiumSessionRestore-iOS [iOS] - Fix #32840: Disable Chromium Session-Restore for WebState and WebViews --------- Co-authored-by: Kyle Hickinson <[email protected]> Co-authored-by: Ralph Giles <[email protected]> Co-authored-by: brave-builds <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#32840
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: