Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Copy/Edit Icons & URL/Text Paste Option upon tapping URL #38507

Closed
3 of 6 tasks
hairycactus opened this issue May 22, 2024 · 9 comments · Fixed by brave/brave-core#23796
Closed
3 of 6 tasks

Missing Copy/Edit Icons & URL/Text Paste Option upon tapping URL #38507

hairycactus opened this issue May 22, 2024 · 9 comments · Fixed by brave/brave-core#23796

Comments

@hairycactus
Copy link

hairycactus commented May 22, 2024

Description

When the URL bar (with text) is tapped & the text1 automatically gets highlighted, the Share | Copy | Edit icons & the Link/Text you copied option are missing.

Impact: User is unable to conveniently copy/ edit/ share contents of URL bar, or paste into URL bar -- unless user resorts to alternative method as workaround (eg. long-press URL bar to trigger a different type of Copy-Paste non-icon context menu).

Steps to reproduce

To Copy URL Bar Contents:

  1. Load any webpage, eg. https://brave.com.
  2. Tap URL bar.
  3. (Not Possible Now): Tap Copy icon on right side below URL bar.

To Paste URL/ Text into URL Bar:

  1. Make sure there is URL/ text in clipboard.
  2. Tap URL bar -- either blank or with existing URL.
  3. (Not Possible Now): Tap Link/ Text you copied text option on left side below URL bar.

Above can be reproduced every time.

Actual result

  1. Blank translucent overlay appears between URL bar & keypad area.
  2. User is not able to quickly copy/ edit/ share contents of URL bar.
  3. Tap empty translucent space to remove it, or else webpage below is not accessible.

Screenshots of Actual/ Abnormal Behaviour:

Screenshot: Brave Android v1.66.110 URL Bar Copy-Paste Bug

Expected result

To Copy URL:

  1. Tap URL bar showing hyperlink.
  2. Whole hyperlink/ text in URL bar gets highlighted.
  3. Tap Copy icon (2 overlapping rectangles) below URL bar.
  4. URL copied floating message is briefly shown at bottom of browser window.

To Paste Copied URL/ Text String into Current/ New Tab:

  1. Tap URL bar (empty or with existing URL/ text).
  2. Tap Link/ Text you copied text row that appears below URL bar.
  3. Browser instantly loads pasted URL, OR loads the search results for pasted text string.

Screenshots of Expected/ Normal Behaviour -- samples collated from various sources:

Screenshot: Brave Android v1.66.110 URL Bar Copy-Paste Bug

Reproduces how often

Easily reproduced

Brave version

Brave Android

  • v1.66.110 x64 Stable (15 May 2024, Google Play Store): Affected
  • v1.66.113 64 Stable (24 May 2024, Google Play Store): Affected
  • v1.65.133 x64 & older: Not Affected
  • Beta & Nightly: Unknown, not tested
  • Extensions Installed: Nil

Device

  • Device Type: Mobile Phone
  • Android Version: v12

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

I can see same missing Share | Copy | Edit Link icons issue in another user's opening screenshot (directly under Actual Result) at #38395.

Initially posted under aforementioned issue, but subsequently realized that user might be talking about something else. So opened this as separate new issue instead.

Footnotes

  1. The text in the URL bar can be anything, eg. hyperlink of loaded webpage (https://brave.com), search result URL (https://www.google.com/search?q=brave+browser), about:blank, etc.

@kjozwiak
Copy link
Member

The above requires 1.66.115 or higher for 1.66.x verification 👍 @Uni-verse @hffvld lets check a few versions of Android for the above just to make sure it's fixed across the board. For example, Android 14, Android 12 etc...

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 using version:

Brave	1.66.115 Chromium: 125.0.6422.112 (Official Build) (64-bit) 
Revision	a168513c9c84b6ba793d5eac01c725982187aeb4
OS	Android 13; Build/TP1A.220624.014; 33; REL
  • Ensured that Share, Copy and Edit icon appears when tapping on URL bar text.
  • Ensured tapping on each of the buttons will perform the correct action.
  • Ensured pasting copied text into URL bar works.
  • Ensured clearing URL bar will present recent URL options with share/copy/edit tools.
  • Ensured tapping on the URL bar in private tabs will display the share/copy/edit tools.
Example Example Example
Screenshot 2024-05-24 at 10 58 55 AM Screenshot 2024-05-24 at 10 58 59 AM Screenshot 2024-05-24 at 10 59 05 AM
Screenshot 2024-05-24 at 10 59 13 AM Screenshot 2024-05-24 at 10 59 27 AM Screenshot 2024-05-24 at 11 03 51 AM

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy Tab S7 running Android 13 using version:

Brave	1.66.115 Chromium: 125.0.6422.112 (Official Build) (64-bit) 
Revision	a168513c9c84b6ba793d5eac01c725982187aeb4
OS	Android 13; Build/TP1A.220624.014; 33; REL
Example Example Example Example Example
Screenshot 2024-05-24 at 11 43 10 AM Screenshot 2024-05-24 at 11 43 26 AM Screenshot 2024-05-24 at 11 43 30 AM Screenshot 2024-05-24 at 11 43 37 AM Screenshot 2024-05-24 at 11 43 48 AM

@hffvld
Copy link
Contributor

hffvld commented May 24, 2024

Verified on Pixel 2 XL, Pixel 6, and Pixel 7 using version(s):

Device/OS: 
- Pixel 2 XL / taimen-user  8.1.0 OPM2.171026.006.H1 release-keys
- Pixel 6 / oriole-user 14 AP1A.240405.002 release-keys
- Pixel 7 / panther_beta-user 14 AP31.240426.022 release-keys
Brave build: 1.68.38 
Chromium: 126.0.6478.17 (Official Build) canary (64-bit) 

STEPS:

  1. Follow the steps from Missing Copy/Edit Icons & URL/Text Paste Option upon tapping URL #38507 (comment)
  2. Verify

ACTUAL RESULTS:

  • Ensured that the Share, Copy, and Edit icons appeared when tapping on URL bar text.
  • Ensured tapping on each of the buttons will perform the correct action.
  • Ensured pasting copied text into the URL bar works.
  • Ensured clearing URL bar will present recent URL options with share/copy/edit tools.
  • Ensured tapping on the URL bar in private tabs will display the share/copy/edit tools.

Pixel 2 XL / Android 8
1 2 3
1 2 3
1 2 3
Pixel 6 / Android 14
1 2 3
1 2 3
1 2 3
Pixel 7 / Android 15
1 2 3
1 2 3
1 2 3

@hairycactus
Copy link
Author

Same problem about Brave Android v1.66.110 (phone) in posted at Brave Community & official Brave Reddit forums as follows.

In case it is relevant for deeper troubleshooting & manual testing of the fixed Brave Android version, the bug may behave slightly differently in different builds of the same Android version. See (1a) NOTE below about Android v12.

1. User isTroopyciuu (22 May 2024): https://community.brave.com/t/option-to-copy-link-from-address-bar/549704

a. Android v12 SP1A.210812.016: Affected for all URLs

  • If URL bar's contents are deleted, the missing Share | Copy | Edit Link icons reappear below URL bar
  • NOTE: When I tested Brave Android v1.66.110 & v1.66.113 (just offered to my device on 24 May 2024) in Android v12 SKQ1.211019.00.1, deleting the URL bar's contents do not make the missing icons reappear.

b. **Android v9: Partly Affected

  • Domain Name/ Homepage URLs: OK
  • Non-Homepage URLs/ Domain Name with directory paths: Not OK

Above forum thread was also flagged for attention by @Brave-Matt at a different Github issue #38395.

2. User ChattyCat (20 May 2024): https://community.brave.com/t/address-bar-no-longer-automatically-shows-options-to-share-etc-when-clicked/549366

  • Android Version: Not indicated

3. User TTBOISHYSTA (20 May 2024): https://old.reddit.com/r/brave_browser/comments/1ctgtuh/release_channel_166110/l4v7v4q

So annoying on mobile. Copying the link from the address bar has become clunky.

@hairycactus
Copy link
Author

Just for comparison (Blast from July 2022 Past !), I tested the same function in an old device:

  • Brave (Android) v1.41.100 x64 (Chromium base v103.0.5060.134)
    • Don't know password for account tied to device's Google Play Services, so not able to update Brave to latest version
  • Android v7.1.2

Result: OK, everything works normally
When URL bar is tapped, all Share | Copy | Edit Link icons' functions & paste copied link/text functions work fine -- regardless of type of URL/text, or whether URL bar's contents are deleted or not.

Screenshots:
Brave1.41.100-Android7-URLCopyPasteFunctions-25May24a

Brave1.41.100-Android7-URLCopyPasteFunctions-25May24b

@hairycactus
Copy link
Author

Likely Related ...

Since tapping the URL bar in Brave Android v1.66.110 (16 May 2024) & v1.66.113 (24 May 2024) only shows a blank translucent overlay below the URL bar, this has also caused the listing of user's browsing history (top/ most-visited sites) to disappear from below the URL bar -- as reported below.

Users THEDEEGEE & SYNTHETIC451 (19/21 May 2024):
https://old.reddit.com/r/brave_browser/comments/1ctgtuh/release_channel_166110/l4pokpk

User VENOMO160 (24 May 2024):
https://old.reddit.com/r/brave_browser/comments/1czu31s/on_android_clicking_on_the_address_bar_no_longer

@hairycactus
Copy link
Author

@kjozwiak
The issue seems to be indicated as completed/ resolved in Brave Android v1.66.115 Stable (24 May 2024) ?

But the Share | Copy | Edit icons & the Link/Text you copied option are still missing when the URL bar is tapped -- even though my Brave Android browser had been updated to the following versions so far:

Screenshots (for the latest Stable v1.66.118):

BraveAndroid1.66.118(31May24)-MissingCopyEditPasteOptions-URLBar1

Screenshots (Version Info):

BraveAndroid1.66.118(31May24)-MissingCopyEditPasteOptions-VersionInfo

@kjozwiak
Copy link
Member

@hairycactus do you by any chance have autocomplete in address bar & Leo autocomplete disabled? If that's the case, it would explain why you're not seeing anything when tapping on the URL bar/omnibox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment