Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix for missing edit url suggestion on url focus #23796

Merged
merged 2 commits into from
May 23, 2024

Conversation

samartnik
Copy link
Contributor

Resolves brave/brave-browser#38507

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@samartnik samartnik added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 labels May 23, 2024
@samartnik samartnik added this to the 1.68.x - Nightly milestone May 23, 2024
@samartnik samartnik self-assigned this May 23, 2024
@samartnik samartnik requested a review from a team as a code owner May 23, 2024 01:33
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samartnik samartnik merged commit ca7912f into master May 23, 2024
19 checks passed
@samartnik samartnik deleted the android_edit_url_suggestion_fix branch May 23, 2024 13:11
brave-builds added a commit that referenced this pull request May 23, 2024
brave-builds added a commit that referenced this pull request May 23, 2024
@hffvld
Copy link
Collaborator

hffvld commented May 24, 2024

Verified on Pixel 6 using version(s):

Device/OS: Pixel 6 / oriole-user 14 AP1A.240405.002 release-keys
Brave build: 1.68.41
Chromium: 125.0.6422.76 (Official Build) canary (64-bit) 

STEPS:

  1. Install and launch Brave 1.68.41
  2. Go to any website, for example, www.wikipedia.org
  3. Tap in the URL search bar so, the URL will be selected automatically > Verify
  4. Tap Copy button > Open NTP
  5. Tap in the URL search bar > Verify

ACTUAL RESULTS:

  • Verified that Share, Copy and Edit buttons are available when tapping the URL I the search bar
  • Verified that Linked you copied is shown when tapping on empty URL search bar

1 2 3 4
1 2 3 4

NOTE: I wasn't able to reproduce issue #38507 in any of the channels (Play Store 1.66.110, RC 1.66.113, Beta 1.67.90 and Nightly 1.68.36)

timestamp_18-08-01_18-08-21.mp4
timestamp_18-09-04_18-09-20.mp4

kjozwiak pushed a commit that referenced this pull request May 24, 2024
kjozwiak pushed a commit that referenced this pull request May 24, 2024
@samartnik samartnik restored the android_edit_url_suggestion_fix branch May 27, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Copy/Edit Icons & URL/Text Paste Option upon tapping URL
5 participants