Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show warning on Desktop before enter existing sync chain (uplift to 1.31.x) #10914

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Show warning on Desktop before enter existing sync chain (uplift to 1.31.x) #10914

merged 1 commit into from
Nov 8, 2021

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Nov 5, 2021 •
edited by kjozwiak
Loading

Uplift of #10898
Resolves brave/brave-browser#19233

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@AlexeyBarabash AlexeyBarabash requested a review from a team as a code owner November 5, 2021 18:29
@AlexeyBarabash AlexeyBarabash requested a review from a team November 5, 2021 18:29
@AlexeyBarabash AlexeyBarabash self-assigned this Nov 5, 2021
@AlexeyBarabash AlexeyBarabash added this to the 1.31.x - Release #4 milestone Nov 5, 2021
kjozwiak
kjozwiak approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.31.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per https://github.com/brave/internal/issues/824#issuecomment-962278129.

@kjozwiak kjozwiak merged commit e85352e into 1.31.x Nov 8, 2021
@kjozwiak kjozwiak deleted the pr10898_sync_warn_desktop_1.31.x branch November 8, 2021 15:46
@kjozwiak kjozwiak mentioned this pull request Nov 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@AlexeyBarabash AlexeyBarabash

Labels
None yet
Projects
None yet
Milestone
1.31.x - Release #4
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexeyBarabash @kjozwiak