Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning on Desktop before enter existing sync chain #10898

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

AlexeyBarabash
Copy link
Contributor

Resolves brave/brave-browser#19233 (Desktop part)

Submitter Checklist:

  • [??] I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@AlexeyBarabash AlexeyBarabash added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Nov 5, 2021
@AlexeyBarabash AlexeyBarabash self-assigned this Nov 5, 2021
@AlexeyBarabash AlexeyBarabash requested a review from a team as a code owner November 5, 2021 09:58
@AlexeyBarabash
Copy link
Contributor Author

the only step failed is on macOS
https://ci.brave.com/blue/organizations/jenkins/pr-brave-browser-sync_warn_desktop-macos/detail/pr-brave-browser-sync_warn_desktop-macos/1/pipeline/152/

script.sh: 2: security: not found

DevOps team confirmed the fix is ready and if this is the only failed step, consider it as green, no need to restart or rebase. https://bravesoftware.slack.com/archives/CA5FPHWLF/p1636121974083100?thread_ts=1636120850.082300&cid=CA5FPHWLF

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src ++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants