Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show sync warning when creating new chain on desktop #10954

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

AlexeyBarabash
Copy link
Contributor

Resolves brave/brave-browser#19314

This PR fixes issue from #10898 - now the warning is not shown when creating a new chain.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

I. Don't show warning when creating a new chain

  1. Open brave://settings/braveSync/setup
  2. Press Start a new Sync Chain
  3. Choose Computer
  4. Press OK - expected not to see the warning

II. Show warning when connecting to the sync chain

  1. Open brave://settings/braveSync/setup
  2. Press I have a sync code
  3. Paste words and press Confirm - expected the warning is shown

@AlexeyBarabash AlexeyBarabash added feature/sync CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Nov 9, 2021
@AlexeyBarabash AlexeyBarabash self-assigned this Nov 9, 2021
@AlexeyBarabash AlexeyBarabash force-pushed the desktop_sync_warning_fix_for_new_chain branch from 736f9a6 to 3d50d5f Compare November 9, 2021 18:37
@AlexeyBarabash AlexeyBarabash force-pushed the desktop_sync_warning_fix_for_new_chain branch from 3d50d5f to 2ac3f6b Compare November 10, 2021 12:49
@AlexeyBarabash
Copy link
Contributor Author

Rebased, because CI was keeping fail on the place not from the PR

@AlexeyBarabash AlexeyBarabash merged commit abb44e7 into master Nov 10, 2021
@AlexeyBarabash AlexeyBarabash deleted the desktop_sync_warning_fix_for_new_chain branch November 10, 2021 16:11
@AlexeyBarabash AlexeyBarabash added this to the 1.34.x - Nightly milestone Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warning message when creating sync chain - follow up to 19233
3 participants