Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add isBraveWallet property to window.ethereum (Uplift to 1.38.x) #12825

Conversation

josheleonard
Copy link
Contributor

@josheleonard josheleonard commented Mar 30, 2022

Resolves brave/brave-browser#21949

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Navigate to a webpage (brave.com)
  2. Open the developer console
  3. Type in: window.ethereum.isBraveWallet
  4. expect true

@josheleonard josheleonard requested a review from a team as a code owner March 30, 2022 03:19
@josheleonard josheleonard self-assigned this Mar 30, 2022
@josheleonard josheleonard requested a review from a team March 30, 2022 03:29
@josheleonard josheleonard force-pushed the feature-add-isBrave-property-to-window-dot-ethereum-beta-uplift branch from 8d413ad to 994182a Compare March 30, 2022 20:30
@josheleonard josheleonard added this to the 1.38.x - Beta milestone Mar 31, 2022
@josheleonard josheleonard force-pushed the feature-add-isBrave-property-to-window-dot-ethereum-beta-uplift branch from 994182a to b331d61 Compare March 31, 2022 16:12
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.38.x approved 👍 QA has verified the PR on Nightly as per #12794 (comment).

@kjozwiak kjozwiak merged commit 61d8485 into 1.38.x Apr 5, 2022
@kjozwiak kjozwiak deleted the feature-add-isBrave-property-to-window-dot-ethereum-beta-uplift branch April 5, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants