Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure panels opened via toolbar buttons get closed when clicked again (shields, vpn, wallet) #12903

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

petemill
Copy link
Member

@petemill petemill commented Apr 5, 2022

Resolves brave/brave-browser#22026

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Contributor

@nullhook nullhook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petemill petemill force-pushed the toolbar-button-panels-close branch from 39e3a95 to 31267de Compare April 15, 2022 17:24
@petemill petemill merged commit 895cd06 into master Apr 15, 2022
@petemill petemill deleted the toolbar-button-panels-close branch April 15, 2022 21:42
@petemill petemill added this to the 1.39.x - Nightly milestone Apr 15, 2022
petemill added a commit that referenced this pull request Apr 19, 2022
Ensure panels opened via toolbar buttons get closed when clicked again (shields, vpn, wallet)
@stephendonner
Copy link
Contributor

stephendonner commented Apr 20, 2022

Verified PASSED using

Brave | 1.39.73 Chromium: 101.0.4951.34 (Official Build) nightly (x86_64)
-- | --
Revision | 8f93af5d759634c5256b65997dedd138ed60992f-refs/branch-heads/4951@{#710}
OS | macOS Version 11.6.5 (Build 20G527)

Steps:

  1. installed 1.39.73
  2. launched Brave
  3. enabled Experimental VPN... via brave://flags
  4. clicked Relaunch to restart Brave
  5. clicked on the icons

In all cases, tested:

  • clicking the icon invokes a doorhanger panel, which remains until further, specific click(s)
  • clicking inside the panel does NOT dismiss (expected)
  • clicking again on the icon dismisses the doorhanger panel
  • clicking anywhere outside of the doorhanger panel dismisses it
  • panel is dismissed upon pressing esc
  • context-clicking Wallet and VPN icons shows a Hide [button in toolbar] descriptive text (filed Descriptive text for Wallet and VPN icons on toolbar need to be consistent brave-browser#22436)

petemill added a commit that referenced this pull request Apr 22, 2022
Ensure panels opened via toolbar buttons get closed when clicked again (shields, vpn, wallet)
kjozwiak added a commit that referenced this pull request Apr 22, 2022
Uplift 1.38.x - #12903 from brave/toolbar-button-panels-close
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on Shields, VPN, or Wallet icons should toggle panel shown/hidden; it remains shown
4 participants