-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide original tab search button when pref is off #18814
Conversation
When the preference is turned off, we shouldn't show the button
b368c6f
to
58bfd1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Verification PASSED on
Reproduced the original issue using the STR/Cases outlined via brave/brave-browser#30829 (comment) running
Using the STR/Cases outlined via brave/brave-browser#30829 (comment), verified that the search button was being removed correctly as per the following:
As discussed with @rebron via https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1686290856620189, the |
When the preference is turned off, we shouldn't show the button
Resolves brave/brave-browser#30829
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
This applies to only non-win10 platform.
Manual
Automated
VerticalTabStripBrowserTest.OriginalTabSearchButton