Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide original tab search button when pref is off (uplift to 1.52.x) #18839

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Hide original tab search button when pref is off (uplift to 1.52.x) #18839

merged 1 commit into from
Jun 12, 2023

Conversation

sangwoo108
Copy link
Contributor

@sangwoo108 sangwoo108 commented Jun 9, 2023 •
edited by kjozwiak
Loading

Uplift of #18814
Resolves brave/brave-browser#30829

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@sangwoo108 sangwoo108 requested a review from a team as a code owner June 9, 2023 06:05
@sangwoo108 sangwoo108 changed the title Hide original tab search button when pref is off Hide original tab search button when pref is off (uplift to 1.52.x) Jun 9, 2023
@sangwoo108
Hide original tab search button when pref is off
82cb2e5 
When the preference is turned off, we shouldn't show the button
@sangwoo108 sangwoo108 force-pushed the pr18814_sko/tab-search_1.52.x branch from e02a7da to 82cb2e5 Compare June 11, 2023 23:49
@kjozwiak kjozwiak added this to the 1.52.x - Release #5 milestone Jun 12, 2023
kjozwiak
kjozwiak approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.52.x approved 👍 QA has verified the PR on Nightly as per #18814 (comment).

@kjozwiak kjozwiak merged commit 95f1da8 into 1.52.x Jun 12, 2023
@kjozwiak kjozwiak deleted the pr18814_sko/tab-search_1.52.x branch June 12, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@sangwoo108 sangwoo108

Labels
None yet
Projects
None yet
Milestone
1.52.x - Release #5
Development

Successfully merging this pull request may close these issues.
2 participants
@sangwoo108 @kjozwiak