Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Remove tab groups auto creation flag #20069

Closed
wants to merge 2 commits into from

Conversation

samartnik
Copy link
Contributor

This is uplift of 145681c
Fixes brave/brave-browser#32868

Chromium change:
brave/chromium@aa78b43

[Tab Groups] Remove auto creation and menu order params
Remove tab group auto creation and menu order params as these are
launched in their current and final states.

Tab Group Auto Creation is disabled.
New Tab In Group is first in the context menu.

Bug: 1188370
@samartnik samartnik added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Sep 8, 2023
@samartnik samartnik added this to the 1.58.x - Release milestone Sep 8, 2023
@samartnik samartnik requested a review from a team as a code owner September 8, 2023 14:36
@samartnik samartnik self-assigned this Sep 8, 2023
@samartnik samartnik changed the title [Android] Remove tab groups auto creation [Android] Remove tab groups auto creation flag Sep 8, 2023
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing the above after discussing with @SergeyZhukovsky & @samartnik. The above was already fixed with C117 which was uplifted into 1.58.x via #20025 so there's no need to get the above uplifted.

@kjozwiak kjozwiak closed this Sep 11, 2023
@kjozwiak kjozwiak deleted the android_tab_group_autocreation_fix_1.58.x branch September 11, 2023 19:23
@kjozwiak kjozwiak removed this from the 1.58.x - Release milestone Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants