Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing license files from Prebake with Easylist Cookie #4431

Merged
merged 3 commits into from
Jan 28, 2020

Conversation

ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Jan 25, 2020

prebake list hasn;t been updated since 2018.

adblock-rust request: brave/adblock-rust#67

Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping this up-to-date!

@@ -0,0 +1,4 @@
Name: EasyList Cookie
URL: https://easylist.to/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When there's a repository on GitHub or https://hg.adblockplus.org/, I tried to link to that instead thinking it might be more useful than either the text list or the front page of easylist.to.

In this case, is https://github.com/easylist/easylist/tree/master/easylist_cookie the place where this list is developed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, done @fmarier

@fmarier
Copy link
Member

fmarier commented Jan 28, 2020

I tested this manually in a local branch:

  • git merge ryanbr/easylist
  • npm run build Release (aborting after the licensing script has run)
  • checked src/brave/components/third_party/adblock/LICENSE

@fmarier fmarier merged commit 3802462 into brave:master Jan 28, 2020
@fmarier fmarier added this to the 1.5.x - Nightly milestone Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants