Skip to content
This repository was archived by the owner on May 10, 2024. It is now read-only.

Cookie consent options #1358

Closed
anthonypkeane opened this issue Aug 8, 2019 · 24 comments · Fixed by #5839
Closed

Cookie consent options #1358

anthonypkeane opened this issue Aug 8, 2019 · 24 comments · Fixed by #5839

Comments

@anthonypkeane
Copy link

Description:

In the EU, almost every website displays a pop up asking users to agree to their cookies. As a user this is v annoying.
There are many product that offer this consent management, one being Quantcast Choice (https://www.quantcast.com/gdpr/consent-management-solution/)

Can we have an option in Privacy that allows users to not see these pop-ups?
The text can be something like:
Hide Cookie consent pop-ups

cc @johnnyryan and @tomlowenthal for approval

@jamesmudgett
Copy link
Contributor

Might be better as a shield?

@johnnyryan
Copy link

johnnyryan commented Aug 12, 2019

I answered on Slack in this thread https://bravesoftware.slack.com/archives/C4EE00THC/p1565345327108900?thread_ts=1565340552.108800&cid=C4EE00THC

If we target the adtech 3rd parties using the IAB consent design, which most companies are using, and if we make it very clear to the user what they are deciding to switch on, then I think this is a very good idea.

@anthonypkeane anthonypkeane added this to the 1.14 milestone Nov 6, 2019
@anthonypkeane
Copy link
Author

See: brave/brave-browser#5318
for more info

@kylehickinson kylehickinson added blocked: needs design Needs design before work can commence blocked: needs info Needs further information before work can commence labels Nov 11, 2019
@kylehickinson
Copy link
Collaborator

  1. Needs design: Where is this going? Is it a shield?
    • If it is a shield, will it be domain level with a master switch as other shields are (i.e. user can enable it for N site, or enable it for all and disable it for N site, etc.)
    • If it isn't a shield, will it be a master toggle for all web pages such as "Block all Cookies" and "Private Browsing Only"
  2. Needs info:

@jamesmudgett
Copy link
Contributor

"Block Cookie Dialogs" toggle in settings under "Block all Cookies"

@anthonypkeane
Copy link
Author

anthonypkeane commented Nov 12, 2019

The settings text is:
Under Block all Cookies
add
Block Cookie Dialogs (On|Off)

@snyderp can you please reply to @kylehickinson on 2) Needs info above.
Thanks

@pes10k
Copy link
Collaborator

pes10k commented Nov 12, 2019

@kylehickinson there are two (2.5?) approaches here broadly:

  1. Do what Cliqz is doing and just auto tell the IAB the user doesn't consent by setting those cookies for users. This has a bunch of nasty side effects, including it undoes a lot of our 3p cookie protections (since need to notify these folks, via 3p cookie, that the user has opted out). We'd need to punch a hole in shields (not impossible, but something to be very cautious about…). It also wouldn't address non IAB folks, and other similar popups

  2. Do what @ryanbr does with his anti-cookie message list, which is basically block as much related to the whole system as possible, at any possible vantage point (cosmetic, network, etc). This has the benefit of being pretty easy to deply given our current infrastructure, but I think would cut against @johnnyryan's legal concerns (it also has the typical coverage concerns of filter lists, but thats a "solveable problem" [hand wave])

There are a couple of hybrid options we could consider

  • Still keep the 3p cookie blocking with shields (e.g. don't punch an IAB sized hole in them) but just have the browser inject the relevant cookie into those network requests.

  • go hard on the filter lists, i can build up automation to target these kinds of annoyances. Would be an interesting Brave distinguishing feature (again assuming it doesn't make us go to jail, re @johnnyryan jkjkjkjkj)

If none of those appeal, let me know and I can keep brainstorming

@anthonypkeane
Copy link
Author

We plan on doing 2 @snyderp for now.

@kylehickinson wants to know about the list and has it been set up for iOS, converted etc. He can explain more.

@jhreis jhreis removed this from the 1.14 milestone Nov 15, 2019
@jhreis jhreis removed the blocked: needs design Needs design before work can commence label Nov 15, 2019
@anthonypkeane anthonypkeane added this to the 1.15 milestone Nov 15, 2019
@kylehickinson kylehickinson removed this from the 1.15 milestone Nov 28, 2019
@ryanbr
Copy link

ryanbr commented Jan 25, 2020

Submitted 2 PR's, to replace Prebake (the exisiting cookie list in brave://adblock), given prebake hasn't been updated since 2018.

brave/adblock-rust#67
brave/brave-core#4431

@pes10k
Copy link
Collaborator

pes10k commented Jan 27, 2020

@ryanbr just to double check, these new lists target cookie consent dialogs, or the whole wider set of dialogs (GDPR, CPAA, cookies, etc)?

@kylehickinson these are not currently pulled into iOS at all. Should they be?

@kylehickinson
Copy link
Collaborator

@snyderp We don't currently convert cosmetic rules in ab2cb, if we pull in these lists at the moment, it'll only block loads. If that's fine, we can pull them in. Otherwise we will have to first update ab2cb to convert cosmetic rules as well (including testing these)

@pes10k
Copy link
Collaborator

pes10k commented Jan 27, 2020

If that's fine…

I think that'll have to be a decision the iOS team makes.

update ab2cb…

I think this would be a good capability to have, even if we don't fully exercise it right now

@kylehickinson
Copy link
Collaborator

☝️ cc @brave/ios @anthonypkeane

@ryanbr
Copy link

ryanbr commented Jan 28, 2020

@snyderp Like current prebake list, the Easylist cookie list will just hide the cookie div messages/consent dialogs.

Some sites can't be fixed due to cookies being checked by a website (see: quantcast messages).

@anthonypkeane anthonypkeane added this to the 1.16 milestone Jan 30, 2020
@anthonypkeane
Copy link
Author

For a setting add

Block Cookie Dialogs toggle in settings under Block all Cookies
Default is On

@jhreis jhreis removed this from the 1.16 milestone Apr 22, 2020
@iccub iccub removed the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Sep 28, 2022
@cuba cuba closed this as completed in 333b3ea Nov 2, 2022
iccub pushed a commit that referenced this issue Nov 2, 2022
@iccub iccub added this to the 1.45 milestone Nov 2, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Nov 9, 2022

Verified using version 1.45 (22.11.8.15) on the following device(s):

iPhone 12 - iOS 16.x
iPhone XR - iOS 15.x
iPhone X - iOS 14.x
iPads - iPadOS 16.x, 15.x

Acceptance Criteria: #5839 (comment)

Case: user clicks on "Yes block cookie consent notices" on the popup:

  • Verified that the setting is enabled in shields
  • Verified the cookie notice blocking filter list is enabled
  • Verified the animation plays and then the popup disappears

Case: user clicks on "No thanks" on the popup

  • Verified the setting is not enabled in shields
  • Verified the cookie notice blocking filter list is not enabled
  • Verified the popup is dismissed

Case: User enables the settings:

  • Verified - the popup doesn't appear on second launch (Note: you will need to enabled it on first launch)
  • Verified - the cookie consent notices are blocked

Case: When the setting is not enabled:

  • Verified - the popup appears on a second launch (note that depending on timing other full screen popups might appear in priority)

  • Verified - Cookie consent notices are not blocked

  • Verified synchronization between the cookie blocking setting in shields and the filter list is enabled in filter lists screen

  • Verified setting is held when app is terminated/relaunched.

Example Example Example Example Example
IMG_4091 IMG_4092 IMG_4093 IMG_4082 IMG_4095
Example Example Example Example
IMG_0027 2 IMG_0028 IMG_0029 2 IMG_0030 2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.