Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates l10n for Chromium 84 (1.11.x). #6084

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#10735
Uplift from #6075

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Upldates l10n for Chromium 84.
@mkarolin mkarolin added this to the 1.11.x - Release milestone Jul 15, 2020
@mkarolin mkarolin requested a review from a team July 15, 2020 03:12
@mkarolin mkarolin self-assigned this Jul 15, 2020
@mkarolin
Copy link
Collaborator Author

CI: audit-deps failed on all platforms - a known unrelated issue.
Android unit-tests failed to run.
Windows browser-test failure and install-test failure, will rerun.

@mkarolin mkarolin added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Jul 15, 2020
@mkarolin
Copy link
Collaborator Author

mkarolin commented Jul 15, 2020

CI: on the consecutive run Android unit-tests and Windows browser-tests all succeeded. Test-install on Windows still failed, but don't believe it's related to the PR.

@kjozwiak kjozwiak changed the title Upldates l10n for Chromium 84 (1.11.x). Updates l10n for Chromium 84 (1.11.x). Jul 15, 2020
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.11.x approved after deliberating with @brave/uplift-approvers. QA will go through a few locales as a spot check in the next 1.11.x build to make sure nothing obvious regressed.

@kjozwiak kjozwiak merged commit a92edf5 into 1.11.x Jul 15, 2020
@kjozwiak kjozwiak deleted the maxk-cr84-l10n-1.11.x branch July 15, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants