Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes estimated pending rewards for Ads resets to Zero in NTP after browser restart until ads has initialized #8208

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Mar 10, 2021

Resolves brave/brave-browser#13267

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Estimated pending rewards on the Rewards widget will show as 0.00 for the first-run until ads is initialized and the new values populated. Thereafter ads will work as expected.

See brave/brave-browser#13267

@tmancey tmancey self-assigned this Mar 10, 2021
@tmancey tmancey force-pushed the issues/13267 branch 2 times, most recently from 35c7369 to a8e9fb0 Compare March 10, 2021 17:49
@tmancey tmancey requested a review from emerick March 11, 2021 08:40
@tmancey tmancey force-pushed the issues/13267 branch 3 times, most recently from 1a59054 to b0cf396 Compare March 11, 2021 21:41
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey force-pushed the issues/13267 branch 7 times, most recently from 067066c to e2c071e Compare March 12, 2021 16:51
@tmancey tmancey requested a review from kylehickinson as a code owner March 12, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Estimated pending rewards for Ads resets to Zero in NTP after browser restart until ads has initialized
4 participants