Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes estimated pending rewards for Ads resets to Zero in NTP after browser restart until ads has initialized - 1.22.x #8245

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Fixes estimated pending rewards for Ads resets to Zero in NTP after browser restart until ads has initialized - 1.22.x #8245

merged 1 commit into from
Mar 16, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Mar 13, 2021 •
edited by kjozwiak
Loading

Uplift of #8208
Resolves brave/brave-browser#13267

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey added this to the 1.22.x - Beta milestone Mar 13, 2021
@tmancey tmancey requested a review from a team March 13, 2021 09:52
@tmancey tmancey requested a review from kylehickinson as a code owner March 13, 2021 09:52
@tmancey tmancey self-assigned this Mar 13, 2021
@kjozwiak
Copy link
Member

audit_deps failed in post-init due to a known failure as per https://ci.brave.com/job/pr-brave-browser-issues-13267-1.22.x-post-init/1/execution/node/145/log/. However, the failure isn't related to this specific PR hence not blocking uplift.

kjozwiak
kjozwiak approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.22.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nighty as per brave/brave-browser#13267 (comment).

@kjozwiak kjozwiak merged commit 3dc4ba2 into 1.22.x Mar 16, 2021
@kjozwiak kjozwiak deleted the issues/13267-1.22.x branch March 16, 2021 17:05
@kjozwiak kjozwiak mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@kylehickinson kylehickinson Awaiting requested review from kylehickinson kylehickinson is a code owner

Assignees

@tmancey tmancey

Labels
feature/ads
Projects
None yet
Milestone
1.22.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @kjozwiak