Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulled latest l10n fixes for 1.23.x release. #8510

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#15241

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin requested review from bbondy and emerick April 12, 2021 19:17
@mkarolin mkarolin self-assigned this Apr 12, 2021
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkarolin
Copy link
Collaborator Author

CI on Mac failed on s3 upload step, unrelated to this PR.

@mkarolin mkarolin merged commit 3821f24 into master Apr 12, 2021
@mkarolin mkarolin deleted the maxk-release-1.23.x-ja-l10-fix branch April 12, 2021 23:43
brave-builds pushed a commit that referenced this pull request Apr 12, 2021
brave-builds pushed a commit that referenced this pull request Apr 12, 2021
@kjozwiak kjozwiak added this to the 1.25.x - Nightly milestone Apr 14, 2021
kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull in l10n fixes for 1.23.x release.
3 participants