Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulled latest l10n fixes for 1.23.x release. (uplift to 1.23.x) #8519

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Apr 12, 2021

Fixes brave/brave-browser#15241
Uplift of #8510

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team April 12, 2021 23:52
@brave-builds brave-builds self-assigned this Apr 12, 2021
@brave-builds brave-builds added this to the 1.23.x - Release milestone Apr 12, 2021
@kjozwiak
Copy link
Member

Restarting macOS due to unit-test test failing as per https://ci.brave.com/job/pr-brave-browser-pr8510_maxk-release-1.23.x-ja-l10-fix_1.23.x-macos/1/execution/node/205/log/.

00:00:34  FAILED: obj/brave/test/brave_browser_tests/brave_theme_api_browsertest.o 

test-browser failed on Linux due as per https://ci.brave.com/job/pr-brave-browser-pr8510_maxk-release-1.23.x-ja-l10-fix_1.23.x-linux/1/execution/node/241/log/ & https://ci.brave.com/job/pr-brave-browser-pr8510_maxk-release-1.23.x-ja-l10-fix_1.23.x-linux/1/execution/node/244/log/. However, these are known issues that are unrelated to this specific PR.

21:32:19  5 tests crashed:
21:32:19      BraveStatsUpdaterBrowserTest.StatsUpdaterMigration (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:275)
21:32:19      BraveStatsUpdaterBrowserTest.StatsUpdaterSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:154)
21:32:19      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithDefaultReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:229)
21:32:19      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:327)
21:32:19      BraveStatsUpdaterBrowserTest.StatsUpdaterThresholdSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:191)

@kjozwiak
Copy link
Member

Restarting macOS due to build failing as per https://ci.brave.com/job/pr-brave-browser-pr8510_maxk-release-1.23.x-ja-l10-fix_1.23.x-macos/2/execution/node/164/log/.

05:44:10  FAILED: obj/third_party/blink/renderer/bindings/modules/v8/bindings_modules_impl/gpu_swap_chain_descriptor.o 

@kjozwiak
Copy link
Member

test-browser failed on macOS as per https://ci.brave.com/job/pr-brave-browser-pr8510_maxk-release-1.23.x-ja-l10-fix_1.23.x-macos/3/execution/node/241/log/ & https://ci.brave.com/job/pr-brave-browser-pr8510_maxk-release-1.23.x-ja-l10-fix_1.23.x-macos/3/execution/node/244/log/. However, these are known crashes and untreated to this specific PR.

10:49:08  5 tests crashed:
10:49:08      BraveStatsUpdaterBrowserTest.StatsUpdaterMigration (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:275)
10:49:08      BraveStatsUpdaterBrowserTest.StatsUpdaterSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:154)
10:49:08      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithDefaultReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:229)
10:49:08      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:327)
10:49:08      BraveStatsUpdaterBrowserTest.StatsUpdaterThresholdSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:191)

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.23.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit e1ee11a into 1.23.x Apr 13, 2021
@kjozwiak kjozwiak deleted the pr8510_maxk-release-1.23.x-ja-l10-fix_1.23.x branch April 13, 2021 17:50
kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants