Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] fixes shields share stats layout for tablets and landscape #8807

Merged
merged 2 commits into from
Jun 15, 2021

Conversation

alexsafe
Copy link
Contributor

Resolves brave/brave-browser#15777

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

included in the issue

@alexsafe alexsafe added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels May 14, 2021
@alexsafe alexsafe added this to the 1.26.x - Nightly milestone May 14, 2021
@alexsafe alexsafe requested a review from deeppandya May 14, 2021 16:19
@alexsafe alexsafe self-assigned this May 14, 2021
@alexsafe alexsafe requested a review from samartnik May 14, 2021 16:22
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexsafe alexsafe force-pushed the share-stats-tablet-layout branch from 645610a to eb4ab6b Compare May 17, 2021 22:35
Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsafe alexsafe force-pushed the share-stats-tablet-layout branch 5 times, most recently from b394bd1 to 98bd43e Compare May 22, 2021 14:23
@alexsafe alexsafe force-pushed the share-stats-tablet-layout branch from 98bd43e to 49b25f5 Compare June 3, 2021 22:54
@alexsafe alexsafe force-pushed the share-stats-tablet-layout branch from 49b25f5 to 5a6a7fb Compare June 4, 2021 18:35
@alexsafe alexsafe requested a review from deeppandya June 4, 2021 19:24
@alexsafe
Copy link
Contributor Author

alexsafe commented Jun 4, 2021

made a few changes to the tablet layouts

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsafe alexsafe merged commit 1e41c9c into master Jun 15, 2021
@alexsafe alexsafe deleted the share-stats-tablet-layout branch June 15, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blocked count is not properly aligned on tablet
3 participants