Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocked count is not properly aligned on tablet #15777

Closed
srirambv opened this issue May 12, 2021 · 6 comments · Fixed by brave/brave-core#8807
Closed

Blocked count is not properly aligned on tablet #15777

srirambv opened this issue May 12, 2021 · 6 comments · Fixed by brave/brave-core#8807
Assignees
Labels
android-tablet-specific bug design A design change, especially one which needs input from the design team OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android Tab QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Blocked count is not properly aligned on tablet

Steps to reproduce

  1. Install 1.25.57 x64 build
  2. Visit a page that has a lot of trackers
  3. Open shields, block count is on extreme left which makes it look really bad

Actual result

image

Expected result

Have a smaller shields design so even if something is bad doesn't look obvious

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? No
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Tablet
  • Android version: 10

Brave version

1.25.57

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

#10690 was closed as duplicate but still needs to be fixed. Shields looks awfully bad on tablets
cc: @deeppandya @alexsafe @anthonypkeane @karenkliu

@srirambv srirambv added bug design A design change, especially one which needs input from the design team QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality android-tablet-specific labels May 12, 2021
@anthonypkeane anthonypkeane added the priority/P2 A bad problem. We might uplift this to the next planned release. label May 12, 2021
@srirambv
Copy link
Contributor Author

srirambv commented Jun 1, 2021

Issue seems to be fixed on the current beta build 1.26.46. Block count seems better placed than before. Although real fix is when the shields size is decreased (#10690 closed as dupe)

image

@srirambv srirambv closed this as completed Jun 2, 2021
@srirambv srirambv reopened this Jun 2, 2021
@anthonypkeane anthonypkeane added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Jun 2, 2021
@anthonypkeane
Copy link

cc'ing @karenkliu on this one design eyes.
@alexsafe for implementing when you get time. Thanks

@karenkliu
Copy link

This seems like a dupe of #15635 ?

@srirambv
Copy link
Contributor Author

srirambv commented Aug 2, 2021

Verification passed on Samsung Tab A with Android 10 running 1.28.99 x64 Beta Build

  • Verified blocked count is properly aligned on shields

@karenkliu
Copy link

karenkliu commented Aug 2, 2021

This is still missing the background treatment behind the count, label, info icon, and share icon:

image

@srirambv
Copy link
Contributor Author

srirambv commented Aug 3, 2021

Will add an new follow up issue for that Added follow up issue #17312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android-tablet-specific bug design A design change, especially one which needs input from the design team OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants