Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Update windows tor binaries to 0.3.3.7 #14463

Closed
jumde opened this issue Jun 19, 2018 · 4 comments
Closed

Update windows tor binaries to 0.3.3.7 #14463

jumde opened this issue Jun 19, 2018 · 4 comments
Labels
feature/tor needs-info Another team member needs information from the PR/issue opener. OS/Windows QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@jumde
Copy link
Contributor

jumde commented Jun 19, 2018 •
edited by srirambv
Loading

#Test plan

  1. Install tor build
  2. Open %AppData%\Roaming\brave\tor\data\tor.log
  3. Should show the current Tor binaries used

https://blog.torproject.org/tor-0337-released
@riastradh-brave riastradh-brave mentioned this issue Jun 21, 2018
Merged
11 tasks
@diracdeltas diracdeltas added this to the 0.23.x (Beta Channel) milestone Jun 22, 2018
diracdeltas pushed a commit that referenced this issue Jun 22, 2018
@riastradh-brave @diracdeltas
Adapt package_tor.js to the mingw build of tor. (#14507)
ed07aaa 
* Adapt package_tor.js to the mingw build of tor.

fix #14463 

Auditors: @jumde @diracdeltas

Test Plan:
1. Install Brave on Windows.
2. Launch it.
3. Browse around in a tab with Tor enabled.

* No more need for unzip.

* Updating hash for windows binary

* update package-lock
@bsclifton
Copy link
Member

Fixed with #14507

diracdeltas pushed a commit that referenced this issue Jun 22, 2018
@riastradh-brave @diracdeltas
Adapt package_tor.js to the mingw build of tor. (#14507)
30fa290 
* Adapt package_tor.js to the mingw build of tor.

fix #14463 

Auditors: @jumde @diracdeltas

Test Plan:
1. Install Brave on Windows.
2. Launch it.
3. Browse around in a tab with Tor enabled.

* No more need for unzip.

* Updating hash for windows binary

* update package-lock
bsclifton pushed a commit that referenced this issue Jun 23, 2018
@riastradh-brave @bsclifton
Adapt package_tor.js to the mingw build of tor. (#14507)
8a8439f 
* Adapt package_tor.js to the mingw build of tor.

fix #14463 

Auditors: @jumde @diracdeltas

Test Plan:
1. Install Brave on Windows.
2. Launch it.
3. Browse around in a tab with Tor enabled.

* No more need for unzip.

* Updating hash for windows binary

* update package-lock
@kjozwiak kjozwiak added needs-info Another team member needs information from the PR/issue opener. QA/test-plan-required labels Jun 25, 2018
@kjozwiak
Copy link
Member

@jumde @diracdeltas is there a way to check which version is being used on Windows? It seems like running Brave through the command prompt doesn't output as much information as macOS & Linux does. Example:

screen shot 2018-06-25 at 2 08 24 am

@kjozwiak kjozwiak mentioned this issue Jun 25, 2018
Closed
@srirambv
Copy link
Collaborator

@kjozwiak binaries shows in tor log. Looks good on Windows
image

Verified on Windows 10 x64 using

  • 0.23.16 - 2042c45
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

bsclifton pushed a commit that referenced this issue Jun 25, 2018
@riastradh-brave @bsclifton
Adapt package_tor.js to the mingw build of tor. (#14507)
770732a 
* Adapt package_tor.js to the mingw build of tor.

fix #14463 

Auditors: @jumde @diracdeltas

Test Plan:
1. Install Brave on Windows.
2. Launch it.
3. Browse around in a tab with Tor enabled.

* No more need for unzip.

* Updating hash for windows binary

* update package-lock
@kjozwiak
Copy link
Member

Thanks @srirambv 👍 Probably should have checked the logs first ;)

bsclifton pushed a commit that referenced this issue Jun 26, 2018
@riastradh-brave @bsclifton
Adapt package_tor.js to the mingw build of tor. (#14507)
87b25cc 
* Adapt package_tor.js to the mingw build of tor.

fix #14463 

Auditors: @jumde @diracdeltas

Test Plan:
1. Install Brave on Windows.
2. Launch it.
3. Browse around in a tab with Tor enabled.

* No more need for unzip.

* Updating hash for windows binary

* update package-lock
bsclifton pushed a commit that referenced this issue Jun 27, 2018
@riastradh-brave @bsclifton
Adapt package_tor.js to the mingw build of tor. (#14507)
cc65734 
* Adapt package_tor.js to the mingw build of tor.

fix #14463 

Auditors: @jumde @diracdeltas

Test Plan:
1. Install Brave on Windows.
2. Launch it.
3. Browse around in a tab with Tor enabled.

* No more need for unzip.

* Updating hash for windows binary

* update package-lock
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/tor needs-info Another team member needs information from the PR/issue opener. OS/Windows QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
6 participants
@diracdeltas @jumde @kjozwiak @bsclifton @srirambv @LaurenWags