Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

adding Tor version into "about:brave" #14539

Closed
kjozwiak opened this issue Jun 25, 2018 · 5 comments
Closed

adding Tor version into "about:brave" #14539

kjozwiak opened this issue Jun 25, 2018 · 5 comments

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Jun 25, 2018

Test plan

See #14543

Description

Maybe we won't have enough time to do this in the initial release, but I think it would be a good idea to include which Tor version Brave is using within about:brave. This way, users that don't know how to run Brave via a terminal/console and quickly check which version is being used.

Steps to Reproduce

  1. launch 0.23.x which includes Tor PT's
  2. open about:brave

Actual result:

We're not listing the Tor version within about:brave. Users will need to run brave through the terminal/console to see which version of Tor is being used. Windows doesn't really output this information either. See #14463 (comment)

Expected result:

Users should be able to load about:brave and see which version of Tor is currently being used.

Reproduces how often:

100% reproducible using the latest 0.23.x build.

Brave Version

about:brave info:

Brave: 0.23.16 
V8: 6.7.288.46 
rev: 2042c4572e43fed49765fb3fc8f26d5a7293ac75 
Muon: 7.1.1 
OS Release: 17.5.0 
Update Channel: Release 
OS Architecture: x64 
OS Platform: macOS 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 67.0.3396.87

Reproducible on current live release:

Not reproducible in the current released build as Tor is a new feature that's being released in 0.23.x.

Additional Information

@srirambv
Copy link
Collaborator

+1 on adding info in about:brave.

@LaurenWags
Copy link
Member

+1 from me

@bsclifton
Copy link
Member

Fixed with #14543

@srirambv
Copy link
Collaborator

srirambv commented Jun 25, 2018

image

screen shot 2018-06-25 at 1 20 56 pm

screen shot 2018-06-25 at 2 42 44 pm

@kjozwiak
Copy link
Member Author

@riastradh-brave @bsclifton @diracdeltas thanks for getting this into 0.23.x 👍

bsclifton pushed a commit that referenced this issue Jun 26, 2018
bsclifton pushed a commit that referenced this issue Jun 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants