Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

CSS and font resources are shown in blocked scripts list in shields #14582

Closed
yrliou opened this issue Jun 27, 2018 · 4 comments · Fixed by brave/muon#627
Closed

CSS and font resources are shown in blocked scripts list in shields #14582

yrliou opened this issue Jun 27, 2018 · 4 comments · Fixed by brave/muon#627
Assignees
@darkdh
Labels
priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.23.x Release 3 ...

Comments

@yrliou
Copy link
Member

yrliou commented Jun 27, 2018 •
edited by srirambv
Loading

Test plan

  1. Clean install beta build
  2. Visit https://brianbondy.com/
  3. Turn on block scripts in shields
  4. Ensure CSS and font resources are not blocked

Description

Starting from C67.

Steps to Reproduce

  1. Visit https://brianbondy.com/
  2. Turn on Block Scripts in shields

Actual result:
Our current result starting from C67.
bl-c67-script-blocked-list

Expected result:
Our result before on C66
bl-c66-script-blocked-list

Reproduces how often:
Always

Brave Version

about:brave info:
Brave: 0.22.810
V8: 6.7.288.43
rev: 8f30eeb
Muon: 7.0.6
OS Release: 17.6.0
Update Channel: Release
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 67.0.3396.71

Reproducible on current live release:
Yes
@diracdeltas diracdeltas added this to the 0.23.x Release 2 milestone Jun 27, 2018
@diracdeltas diracdeltas added the priority/P3 Major loss of function. label Jun 27, 2018
@BrendanEich
Copy link
Member

Chromium upgrade changed how an API callback is invoked? Cc: @darkdh

@darkdh darkdh self-assigned this Jul 2, 2018
@darkdh
Copy link
Member

darkdh commented Jul 2, 2018

I have a fix, stay tuned. I'm going to open a PR.

darkdh added a commit to brave/muon that referenced this issue Jul 2, 2018
@darkdh
Check resource type is javascript before calling
83c6801 
`AllowScriptFromSourceWithoutNotifying` which will eventuall lead us to
`ContentSettingsObserver::AllowScriptFromSource`

https://chromium.googlesource.com/chromium/src/+/ea9b5b7daa1d3390b600f2efcaaa5ce3444bc244
It was safe before this commit because persistent client hint feature
wasn't enabled by default

fix brave/browser-laptop#14582

Auditors: @bridiver, @bbondy
@darkdh darkdh mentioned this issue Jul 2, 2018
Merged
This was referenced Jul 10, 2018
Closed
Closed
Closed
@kjozwiak
Copy link
Member

Currently not merged into muon: 7.1.5. Requires muon: 7.1.6.

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Jul 12, 2018 •
edited
Loading

Verified on Windows x64 with the following:

  • 0.23.34 a471718
  • Muon 7.1.6
  • libchromiumcontent 67.0.3396.103

Note: The below two scripts are blocked:

Verified with macOS 10.12.6 using

  • 0.23.34 a471718
  • Muon 7.1.6
  • libchromiumcontent 67.0.3396.103
  • same scripts as above are blocked

Verified on Ubuntu 17.10 x64

  • 0.23.34 a471718
  • Muon 7.1.6
  • libchromiumcontent 67.0.3396.103

Verified on Windows x64 with
• 0.23.37 47b1b59
• Muon 7.1.6
• libchromiumcontent 67.0.3396.103

@kjozwiak kjozwiak mentioned this issue Jul 17, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.23.x Release 3 (Release Channel)
Development

Successfully merging a pull request may close this issue.

Check resource type is javascript before calling AllowScriptFromSourceWithoutNotifying brave/muon
9 participants
@BrendanEich @diracdeltas @kjozwiak @yrliou @darkdh @srirambv @LaurenWags @btlechowski @GeetaSarvadnya