This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Check resource type is javascript before calling AllowScriptFromSourceWithoutNotifying #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`AllowScriptFromSourceWithoutNotifying` which will eventuall lead us to `ContentSettingsObserver::AllowScriptFromSource` https://chromium.googlesource.com/chromium/src/+/ea9b5b7daa1d3390b600f2efcaaa5ce3444bc244 It was safe before this commit because persistent client hint feature wasn't enabled by default fix brave/browser-laptop#14582 Auditors: @bridiver, @bbondy
bridiver
approved these changes
Jul 2, 2018
9 tasks
darkdh
added a commit
to brave/brave-core
that referenced
this pull request
Jul 3, 2018
out problem like brave/muon#627 which `ContentSettingsObserver::AllowScriptFromSource` informs us all the resources not just scripts Auditors: @bridiver, @bbondy
darkdh
added a commit
that referenced
this pull request
Jul 11, 2018
Check resource type is javascript before calling AllowScriptFromSourceWithoutNotifying
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which will eventuall lead us to
ContentSettingsObserver::AllowScriptFromSourcehttps://chromium.googlesource.com/chromium/src/+/ea9b5b7daa1d3390b600f2efcaaa5ce3444bc244
It was safe before this commit because persistent client hint feature
wasn't enabled by default
fix brave/browser-laptop#14582
Auditors: @bridiver, @bbondy