Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmarking into folders dupes or doesn't work #7014

Closed
ayumi opened this issue Feb 3, 2017 · 2 comments · Fixed by #7024
Closed

Bookmarking into folders dupes or doesn't work #7014

ayumi opened this issue Feb 3, 2017 · 2 comments · Fixed by #7024
Assignees
@darkdh
Labels
bug feature/bookmarks QA/checked-Win64 QA/test-plan-required release-notes/exclude
Milestone
0.13.2

Comments

@ayumi
Copy link
Contributor

ayumi commented Feb 3, 2017 •
edited
Loading

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Bookmarking into folders dupes or doesn't work.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    MacOS 10.11.6

  • Brave Version (revision SHA):
    0.13.2-rc1; master @cfa3186ddc7a0631044f482fe1758d72fb84ad83

  • Steps to reproduce:
    0. Open Brave and enable the bookmarks toolbar.

    1. Create a folder on the toolbar.
    2. Visit a page. Bookmark it by clicking the URL bar star, specifying the folder you created.
    3. Bookmark is duplicated to be both in the folder and on the toolbar.
    4. Visit another page. Bookmark it by dragging the padlock onto the toolbar folder.
    5. Bookmark is not in the folder; instead it's on the toolbar.

  • Actual result:
    The bookmarking common case (Click the Star / Cmd+D) duplicates when bookmarking into folders.
    Drag to bookmark can't bookmark into folders.

  • Expected result:
    Bookmarking into folders should work normally.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Fresh– yes

  • Is this an issue in the currently released version?
    N (current RC)

  • Can this issue be consistently reproduced?
    Y

  • Any related issues:
    maybe Adding bookmarks creates multiple entries(Intermittent issue) #6510
@ayumi ayumi changed the title Bookmarking into folders fails sometimes Bookmarking into folders dupes or doesn't work Feb 3, 2017
@ayumi ayumi added this to the 0.13.2 milestone Feb 3, 2017
@ayumi ayumi added the bug label Feb 3, 2017
@darkdh darkdh self-assigned this Feb 3, 2017
@darkdh darkdh mentioned this issue Feb 3, 2017
Closed
@darkdh
Copy link
Member

darkdh commented Feb 3, 2017

drag and drop problem is not regression. so I separated it from here to #7019

darkdh added a commit that referenced this issue Feb 3, 2017
@darkdh
Harden addSite and moveSite
fc20174 
fix #7014
fix #7016

Auditors: @bbondy, @ayumi

Test Plan: covered by automatic test
@darkdh darkdh mentioned this issue Feb 3, 2017
Merged
4 tasks
This was referenced Feb 3, 2017
Closed
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Feb 3, 2017

Steps mentioned in the original issue. Bookmark is shown correctly under the folder and not under root folder

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
bug feature/bookmarks QA/checked-Win64 QA/test-plan-required release-notes/exclude
Projects
None yet
Milestone
0.13.2
Development

Successfully merging a pull request may close this issue.

Harden addSite and moveSite brave/browser-laptop
4 participants
@ayumi @luixxiul @darkdh @srirambv