Fixed dragging bookmark into a folder on bookmarks toolbar

[darkdh]

Original title: Dragging bookmark into a folder (on bookmarks toolbar) doesn't work; puts at root of toolbar #7019 (comment)

Test plan

1. Create a folder on the toolbar.
2. Visit a page. Bookmark it by dragging the padlock onto the toolbar folder.
3. Bookmark is in the folder, as expected

Original issue description

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  Drag to bookmark into folder on toolbar doesn't work

• Platform (Win7, 8, 10? macOS? Linux distro?): macOS

• Brave Version (revision SHA): 0.13.0

• Steps to reproduce:

  1. Create a folder on the toolbar.
  2. Visit a page. Bookmark it by dragging the padlock onto the toolbar folder.
  3. Bookmark is not in the folder; instead it's on the toolbar.

• Actual result:
  Bookmark is not in the folder; instead it's on the toolbar.

• Expected result:
  Bookmark is in the folder

• Will the steps above reproduce in a fresh profile? If not what other info can be added?

• Is this an issue in the currently released version?

• Can this issue be consistently reproduced?

• Extra QA steps:
  1.
  2.
  3.

• Screenshot if needed:

• Any related issues:
  separated from Bookmarking into folders dupes or doesn't work #7014

[bsclifton]

Updated description; I hate this bug! 🐛 🐞

[srirambv]

With 0.13.5, this is not happening. Bookmarks is properly shown under folder, but it is not showing in the change of location in menu.

[NejcZdovc]

You can do changes in bookmark manager and changes will not be visible in the bookmarks menu, so I think this is a new issue (regression). I could only see the changes if I restart the browser.

[bsclifton]

As annoying as this bug (I seriously hate it), I'm going to move to 0.14.3 since there isn't an owner yet

[bsclifton]

@srirambv can you retest? this may have been fixed by 62665a5

[srirambv]

@bsclifton Its still not. Also just realized, empty bookmark folder doesn't have a folder > to the file name to indicate its a folder.

[bsclifton]

Works great for me on both macOS and Windows; I captured the following with Preview 3:

Appears to have been fixed with 62665a5