Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

make all info circles in preferences clickable #7864

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Mar 23, 2017

fix #5758

Test Plan:

  1. go to about:preferences#plugins
  2. all the info circle icons should be clickable
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

fix #5758

Test Plan:
1. go to about:preferences#plugins
2. all the info circle icons should be clickable
Copy link

@cndouglas cndouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ thanks

@cezaraugusto cezaraugusto merged commit 574057c into master Mar 24, 2017
@luixxiul luixxiul modified the milestones: 0.14.0, 0.14.1 Mar 24, 2017
@bsclifton bsclifton deleted the fix/5758 branch March 24, 2017 16:13
@bsclifton bsclifton modified the milestones: 0.14.1, 0.14.0 Mar 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixed missing content links for info buttons in preferences
5 participants