Skip to content

Commit

Permalink
CI: Drop allow-failure option in some Ubuntu cases. (#1292)
Browse files Browse the repository at this point in the history
As we fixed some of the issues, we can drop the allow-failure option in some
cases. #1165 was resolved by mysql2 0.5.4, while #1194 needs attention.
  • Loading branch information
junaruga authored Dec 28, 2022
1 parent 6525c02 commit 79c6263
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,20 +30,18 @@ jobs:
include:
# Comment out due to ci/setup.sh stucking.
# - {os: ubuntu-18.04, ruby: 2.4, db: mariadb10.1}
# Allow failure due to the issue #965, #1165.
- {os: ubuntu-20.04, ruby: '2.4', db: mariadb10.3, allow-failure: true}
- {os: ubuntu-20.04, ruby: '2.4', db: mariadb10.3}
- {os: ubuntu-18.04, ruby: '2.4', db: mysql57}
# Allow failure due to the issue #1165.
- {os: ubuntu-20.04, ruby: '2.4', db: mysql80, allow-failure: true}
- {os: ubuntu-18.04, ruby: 'head', db: '', allow-failure: true}
- {os: ubuntu-20.04, ruby: '2.4', db: mysql80}
- {os: ubuntu-18.04, ruby: 'head', db: ''}
# db: A DB's brew package name in macOS case.
# Set a name "db: '[email protected]'" when using an old version.
# MariaDB lastet version
# Allow failure due to the following test failures that rarely happens.
# https://github.com/brianmario/mysql2/issues/1194
- {os: macos-latest, ruby: '2.6', db: mariadb, allow-failure: true}
# MySQL latest version
# Allow failure due to the issue #1165.
# Allow failure due to the issue #1194.
- {os: macos-latest, ruby: '2.6', db: mysql, allow-failure: true}
# On the fail-fast: true, it cancels all in-progress jobs
# if any matrix job fails unlike Travis fast_finish.
Expand Down

0 comments on commit 79c6263

Please sign in to comment.