CI: Drop allow-failure option in some Ubuntu cases. #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we fixed some of the issues, we can drop the allow-failure option in some cases.
|
According this, there is no problem with ruby 3?, Just 2.6? |
Are you talking about the MacOS ruby 2.6 case? I am not sure. Maybe you can test it on your forked repo by changing the "2.6" to "3.0" if you like. |
|
Thanks for checking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we fixed some of the issues, I think that we can drop the allow-failure option in some cases.
I saw the issue #1194 happened on the latest master's MacOS mysql case too. So, I chnaged the issue number from 1165 to 1194.
#1194 (comment)