forked from apache/arrow-rs
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for JSON schema inference #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pache#870) * feat(ipc): Support for writing dictionaries nested in structs and unions Dictionaries are lost when serializing a RecordBatch for IPC, producing invalid arrow data. This PR changes encoded_batch to recursively find all dictionary fields within the schema (currently only in structs and unions) so nested dictionaries are properly serialized. * address lint and clippy
* Use different caching for MIRI runs * Also cache cargo
* Fix unaligned access in bit-packing * Fix creation of unaligned reference in murmur_hash2_64a * Remove now-unnecessary unsafe Co-authored-by: Andrew Lamb <[email protected]>
* Bump deps Signed-off-by: Chojan Shang <[email protected]> * Setup lastest cargo-tarpaulin Signed-off-by: Chojan Shang <[email protected]> * Try to use the lastest cargo Signed-off-by: Chojan Shang <[email protected]> Co-authored-by: Andrew Lamb <[email protected]>
…ures (apache#922) * Move MIRI checks into a shell script * add retry loop
…pache#810) * Validate arguments to ArrayData::new: null bit buffer and buffers * REname is_int_type to is_dictionary_key_type() * Correctly handle self.offset in offsets buffer * Consolidate checks * Fix test output
…ary fields (apache#923) * feat(ipc): read a message containing nested dictionary fields * Apply suggestions from code review Co-authored-by: Andrew Lamb <[email protected]> * address lints Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.
and a link to the issue: 815ea72