Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDO-3517: add eso secrets to data repo #253

Merged
merged 15 commits into from
Apr 2, 2024
Merged

DDO-3517: add eso secrets to data repo #253

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
afc7f43
add eso secrets
katiewelch Mar 5, 2024
f4596b0
condense
katiewelch Mar 5, 2024
5927029
empty list
katiewelch Mar 5, 2024
797109d
refactor eso values
katiewelch Mar 7, 2024
aab6823
if decoding strat
katiewelch Mar 7, 2024
788b0d1
comment
katiewelch Mar 7, 2024
3cc5301
format
katiewelch Mar 7, 2024
c9dfa0e
delete labels
katiewelch Mar 7, 2024
838377e
nesting
katiewelch Mar 22, 2024
167b65a
refresh interval nesting
katiewelch Mar 22, 2024
f9c7c70
remove refresh interval from values
katiewelch Mar 22, 2024
5514ecc
bump chart version to 0.0.7
katiewelch Mar 28, 2024
6c13134
bump app version to 0.0.7
katiewelch Apr 1, 2024
f7a0bcd
update versions in other charts
katiewelch Apr 2, 2024
079eb3c
revert
katiewelch Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions charts/create-secret-manager-secret/templates/vaultsecret.yaml
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to manual bump the version on any of the charts changed:
https://github.com/broadinstitute/datarepo-helm/blob/master/charts/create-secret-manager-secret/Chart.yaml#L17

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,27 @@ spec:
key: {{ .vaultKey }}
{{- end }}
{{- end -}}

{{- range .Values.externalSecrets.secrets }}
---
apiVersion: external-secrets.io/v1beta1
kind: ExternalSecret
metadata:
name: {{ .secretName }}
labels: {{- include "datarepo.labels" . | nindent 4 }}
jack-r-warren marked this conversation as resolved.
Show resolved Hide resolved
spec:
secretStoreRef:
name: cluster-secret-store
kind: ClusterSecretStore
refreshInterval: {{ .Values.externalSecrets.refreshInterval | quote }}
data:
{{- range .data}}
- secretKey: {{ .secretKey}}
remoteRef:
key: {{ .key }}
property: {{ .property }}
{{- if .decodingStrategy }}
decodingStrategy: {{ .decodingStrategy }}
{{- end }}
{{- end}}
{{- end -}}
11 changes: 11 additions & 0 deletions charts/create-secret-manager-secret/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,14 @@ secrets:
# - kubeSecretKey: ## name of kubeSecretKey
# path: ## vault path
# vaultKey: ## vault key name

externalSecrets:
secrets: []
refreshInterval: "5m"

# - secretName: ## name of kubeSecret
# data:
# - secretKey: ## name of kubeSecretKey
# key: ## key name
# property: ## description of secret
# decodingStrategy: ## how to decode secret
Loading