-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDO-3517: add eso secrets to data repo #253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for bearing with me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to manual bump the version on any of the charts changed:
https://github.com/broadinstitute/datarepo-helm/blob/master/charts/create-secret-manager-secret/Chart.yaml#L17
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -14,7 +14,7 @@ type: application | |||
|
|||
# This is the chart version. This version number should be incremented each time you make changes | |||
# to the chart and its templates, including the app version. | |||
version: 0.0.6 | |||
version: 0.0.7 | |||
appVersion: 0.0.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also bump the appVersion to match... I don't know why we have both.
This is the first of 4 PRs to migrate data repo to ESO from Vault. This PR and DDO-3517 in terra-helmfile will add eso secrets to data repo. The ESO secrets will not be used yet, they will sit along side the Vault secrets until PRs 3 & 4.
This repo (datarepo-helm) will hold the create-secret-manager-secret chart while terra-helmfile will hold the values.
This PR was tested by using the datarepo-helm-definitions repo. Using Olivia's setup, I pointed the chart to my local updated version of the create-secret-manager-secrets chart, after updating the values file in the definitions repos. I also pointed the values to my local versions of the terra-helmfile values files for dev, staging, prod, and BEEs.
helmfile.yaml:
After running
helmfile apply
, for each iteration of my local chart and values files, I confirmed the output matches what I expect.