Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDO-3517: add eso secrets to data repo #253

Merged
merged 15 commits into from
Apr 2, 2024
Merged

Conversation

katiewelch
Copy link
Contributor

@katiewelch katiewelch commented Mar 5, 2024

This is the first of 4 PRs to migrate data repo to ESO from Vault. This PR and DDO-3517 in terra-helmfile will add eso secrets to data repo. The ESO secrets will not be used yet, they will sit along side the Vault secrets until PRs 3 & 4.

This repo (datarepo-helm) will hold the create-secret-manager-secret chart while terra-helmfile will hold the values.

This PR was tested by using the datarepo-helm-definitions repo. Using Olivia's setup, I pointed the chart to my local updated version of the create-secret-manager-secrets chart, after updating the values file in the definitions repos. I also pointed the values to my local versions of the terra-helmfile values files for dev, staging, prod, and BEEs.

helmfile.yaml:

# helm releases to be deployed
releases:
  - name: ok-jade-create-secret-manager-secret    # release name
    namespace: ok   # target namespace
    createNamespace: true
    #chart: datarepo-helm/create-secret-manager-secret   # chart name    
    chart: /Users/welchkat/Documents/src/datarepo-helm/charts/create-secret-manager-secret   # chart name
    missingFileHandler: Warn
    values:
      #- create-secret-manager-secret.yaml      # Value files passed via --values
      - /Users/welchkat/Documents/src/terra-helmfile/values/app/datarepo/live/dev.yaml

After running helmfile apply, for each iteration of my local chart and values files, I confirmed the output matches what I expect.

Copy link
Contributor

@jack-r-warren jack-r-warren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for bearing with me

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -14,7 +14,7 @@ type: application

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.0.6
version: 0.0.7
appVersion: 0.0.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also bump the appVersion to match... I don't know why we have both.

@katiewelch katiewelch merged commit a58ccad into master Apr 2, 2024
1 check passed
@katiewelch katiewelch deleted the DDO-3517-add-eso-to-tdr branch April 2, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants