Add autoNotify API for internal use by bugsnag-unity #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
PLAT-6474/auto-notify
branch
2 times, most recently
from
24f1275 to
be74510
Compare
nickdowell
reviewed
May 13, 2021
fractalwrench
force-pushed
the
PLAT-6474/auto-notify
branch
from
be74510 to
af7eeb6
Compare
nickdowell
suggested changes
May 13, 2021
fractalwrench
force-pushed
the
PLAT-6474/auto-notify
branch
2 times, most recently
from
f623cb8 to
6c33809
Compare
fractalwrench
force-pushed
the
PLAT-6474/auto-notify
branch
from
6c33809 to
059a6d3
Compare
|
Added scenarios to macOS test fixture and addressed review comments. |
nickdowell
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Alters bugsnag-cocoa so that it is capable of supporting Unity's AutoNotify API, which allows automatic error detection to be enabled/disabled after Bugsnag has initialized. This is not exposed as part of the Cocoa interface and is intended for internal use by Unity only.
Changeset
autoNotifyas a private property ofBugsnagClientautoNotifyis updatedbsg_kscrash_setHandlingCrashTypesis invoked with the appropriate error types to capture automaticallyTesting
Added E2E tests to verify that
autoNotifyis respected for NSException/Signals, and that error capture behaviour is unaltered if the flag is toggled off then on.