Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SetAutoNotify for Cocoa #253

Merged
merged 1 commit into from
May 14, 2021
Merged

Implement SetAutoNotify for Cocoa #253

merged 1 commit into from
May 14, 2021

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented May 14, 2021 •
edited by kstenerud
Loading

Goal

Alters bugsnag-unity so that it is capable of supporting Unity's AutoNotify API, which allows automatic error detection to be enabled/disabled after Bugsnag has initialized. This builds on the following changes: bugsnag/bugsnag-cocoa#1093

Changeset

  • Disabled app hang detection by default for parity with v5 cocoa behaviour
  • Added separate methods for calling autoNotify on the Cocoa config/client objects

Testing

Tested manually with verification on the dashboard:

  • Bugsnag embedded in a game object with autoNotify true / false
  • Bugsnag initialised in code with config.autoNotify true / false

@kstenerud kstenerud marked this pull request as ready for review May 14, 2021 13:50
@kstenerud kstenerud merged commit 589a691 into integration/unity-native-notifier-uplifts May 14, 2021
@kstenerud kstenerud deleted the PLAT-6474/auto-notify branch May 14, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstenerud kstenerud kstenerud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fractalwrench @kstenerud