Move SpotListener newTicker out of the infinite loop #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mlehner616, I'd be super surprised if this was the cause, but let's fix it anyway. Appreciate you digging into it. @itsdalmo any other ideas? |
This was referenced Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #71
I'm not 100% certain this isn't a red herring. I have to wait for some amount of time see if the leak goes away on my side. pprof didn't show anything hugely out of the ordinary but I could have missed something.
This looks like it was creating a NewTicker on each iteration of the for loop without cleaning it up resulting in a slow increase of CPU churn over time. Moving the NewTicker outside of the loop and setting the case to strike only when the single instance of
tockChansignals should help alleviate growth.