-
Notifications
You must be signed in to change notification settings - Fork 201
Add wasm reference/pointers translation. #1073
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks for working on this. Just to make sure to understand how this moves the needle: this only translates from wasm to clif (obviously), but since enable_safepoints is still a thing, embedders need to explicitly enable it, which means implementing more on their side. Is that right? (I am just checking that this won't break e.g. all of Spidermonkey testing.0) |
Correct, this patch mostly prepares cranelift API surface to add wasmtime anyref tests and, for me, to continue wasmtime-api work. You need to specify |
66f220c
to
59ece79
Compare
Hey @yurydelendik, no pressure here, just wanted to check in what the status of this PR is, and if there's a way we can help?` |
I'm seeking the initial feedback, and if I'm close to the "target" I'll rebase that in timely manner. Either way #1176 is the related issue and might influence this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the slow review here, but this looks good to me, modulo a rebase at this point.
59ece79
to
6334a08
Compare
Cranelift changes to FuncEnvironment, TargetEnvironment, and GlobalInit (see bytecodealliance/cranelift#1073) require these changes to compile wasmtime.
Cranelift changes to FuncEnvironment, TargetEnvironment, and GlobalInit (see bytecodealliance/cranelift#1073) require these changes to compile wasmtime.
Cranelift changes to FuncEnvironment, TargetEnvironment, and GlobalInit (see bytecodealliance/cranelift#1073) require these changes to compile wasmtime.
Cranelift changes to FuncEnvironment, TargetEnvironment, and GlobalInit (see bytecodealliance/cranelift#1073) require these changes to compile wasmtime.
Cranelift changes to FuncEnvironment, TargetEnvironment, and GlobalInit (see bytecodealliance/cranelift#1073) require these changes to compile wasmtime.
Cranelift changes to FuncEnvironment, TargetEnvironment, and GlobalInit (see bytecodealliance/cranelift#1073) require these changes to compile wasmtime.
* Add unimplemented stubs for Cranelift interfaces Cranelift changes to FuncEnvironment, TargetEnvironment, and GlobalInit (see bytecodealliance/cranelift#1073) require these changes to compile wasmtime. * Upgrade Cranelift to 0.52.0
cranelift-wasm is missing conversion of wasm reftypes to cranelift IR. The PR adds capability to translate ref params and locals to IR.
Example: https://gist.github.com/yurydelendik/47b51002f998bccbcad86ace5b62d3d4
/cc @fitzgen