-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cranelift to 0.52.0 #710
Conversation
589194e
to
548b7c0
Compare
It looks like |
It's also failing on |
@abrown @alexcrichton I’ll update the remaining WASI tests to use the latest |
I think it's probably best to disable the wasi tests on beta for now, we can re-enable when it's fixed again. I believe the current bug is rust-lang/rust#67363 and needs to be fixed by either (a) moving everything to the |
I've now migrated all WASI test programs to EDIT: Oh, oops, I think I've mixed the two Rust PRs. So now I'm wondering whether Emscripten is failing because of rust-lang/rust#66308 or rust-lang/rust#67363... |
@abrown @alexcrichton I've now filed #744 which disables the Emscripten job until rust-lang/rust#66308 is resolved. |
b15efb9
to
9bfbf1f
Compare
Cranelift changes to FuncEnvironment, TargetEnvironment, and GlobalInit (see bytecodealliance/cranelift#1073) require these changes to compile wasmtime.
9bfbf1f
to
ff91f21
Compare
Thank you. |
This PR is a bit premature (since Cranelift v0.52.0 has not yet been published) but as I attempt to get SIMD spec tests working I need changes like these to build my locally-changing copy of Cranelift. In talking to @yurydelendik I agreed to push these, but please note the
unimplemented!
used in the newly-exposed methods.[edit: this PR should be good for review now that 0.52.0 is published]