Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined $ reference in react-mutation-mapper #3985

Merged

Conversation

onursumer
Copy link
Member

@onursumer onursumer commented Sep 29, 2021

Related to genome-nexus/genome-nexus#551

This missing import is causing ReferenceError: $ is not defined for external projects using react-mutation-mapper package.

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Copy link
Member

@leexgh leexgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@onursumer onursumer merged commit 0b4b350 into cBioPortal:master Sep 29, 2021
@onursumer onursumer deleted the fix-undefined-jquery-reference branch September 29, 2021 18:28
@inodb inodb added the cl-package Improvements related to a package label Oct 4, 2021
@inodb inodb changed the title Fix undefined $ reference Fix undefined $ reference in react-mutation-mapper Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cl-package Improvements related to a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants