Add exon track to lollipop #103
Conversation
leexgh
force-pushed
the
exon-track
branch
2 times, most recently
from
f720b50 to
a2e84f2
Compare
public/index.html
Outdated
| @@ -4,6 +4,7 @@ | |||
| <!-- Global site tag (gtag.js) - Google Analytics --> | |||
| <script async src="https://www.googletagmanager.com/gtag/js?id=UA-17134933-4"></script> | |||
| <script src="https://kit.fontawesome.com/6be4547409.js" crossorigin="anonymous"></script> | |||
| <script src="https://code.jquery.com/jquery-latest.min.js"></script> | |||
There was a problem hiding this comment.
why do we need this? would it work if we add jQuery as a package.json dependency instead?
There was a problem hiding this comment.
@onursumer Adding jQuery to package.json is not working, I still got "$ is not defined" error
There was a problem hiding this comment.
Are you getting this error from react-mutation-mapper? Can be related to one of the latests updates inside the package.
There was a problem hiding this comment.
@leexgh I just did a quick debug, it is a problem with react-mutation-mapper package. Seems like the problem was introduced by this file https://github.com/cBioPortal/cbioportal-frontend/blob/3675a07a438ad31562b5945e22f71d1be8e7de55/packages/react-mutation-mapper/src/util/LabelUtils.tsx#L11. We should fix the issue there instead of adding a global import in genome-nexus.
There was a problem hiding this comment.
@leexgh I haven't tested it but this PR should fix the issue: cBioPortal/cbioportal-frontend#3985
There was a problem hiding this comment.
Tested locally, it seems working.
| @@ -40,7 +40,7 @@ | |||
| "react": "16.14.0", | |||
| "react-bootstrap": "^1.0.0-beta.6", | |||
| "react-dom": "^16.14.0", | |||
| "react-mutation-mapper": "^0.8.12", | |||
| "react-mutation-mapper": "^0.8.15", | |||
There was a problem hiding this comment.
also update cbioportal-frontend-commons and cbioportal-utils to the latest versions for consistency?
There was a problem hiding this comment.
good point. cbiopoetal-utils is already the latest
Fix: genome-nexus/genome-nexus#551
https://deploy-preview-103--genome-nexus-frontend.netlify.app/variant/7:g.55249071C%3ET