Add functionality to show selected columns in mutations table on init #4435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oplantalech
force-pushed
the
mut_selected_columns
branch
from
47768ee to
b1f2e3d
Compare
alisman
reviewed
Dec 12, 2022
| return; | ||
| } | ||
| const visibleColumns = visibleColumnsProperty.split(','); | ||
| Object.keys(tableColumns).forEach(column => { |
There was a problem hiding this comment.
you don't have to update this but _.forIn(...) will allow you to iterate over members of object and give you both key and value.
|
@oplantalech @pvannierop can you guys fix the CircleCI association of hyve with cbioportal so that these tests will run? If I remember it has something to do with CircleIC Hyve account watching your own fork? |
|
Replaced by #4452 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend implementation of cBioPortal/cbioportal#9912