Add properties to show selected columns in mutations table on init #9912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oplantalech
force-pushed
the
mut_selected_columns
branch
from
ac317e0 to
d6036ab
Compare
|
@oplantalech, is there any convention in the naming of namespace columns? i mean, in their specification, is there any eway to know they are namespace columns? |
|
@alisman Namespaces are only present in the mutation data. They are all prefixed, and the prefixes are defined in the meta_mutation file. More info: https://docs.cbioportal.org/file-formats/#namespaces |
oplantalech
force-pushed
the
mut_selected_columns
branch
from
d6036ab to
30701ef
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
oplantalech
force-pushed
the
mut_selected_columns
branch
from
30701ef to
f2f84c5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
pvannierop
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An organization has added 150 custom namespace columns to the MAF file for studies. They want to visualize two of these are immediately when a user opens Patient View, together with
GeneandProtein Change, while the rest of the columns are hidden in the Columns selection menu.To do so, we propose to introduce two properties that will allow to define the columns that are shown on initialization for the mutation table, one for the results view and the other for the patient view. If the property is not defined, we keep the default columns that are currently shown in the view. Also, the property works together with the
skin.mutation_table.namespace_column.show_by_defaultproperty; if it is set to true, it will show all the namespace columns together with the other defined columns in the properties added in this PR.