Add properties to show selected columns in copy-number and structural variant tables on init #9960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2023
pvannierop
requested changes
Jan 16, 2023
pvannierop
approved these changes
Jan 23, 2023
oplantalech
force-pushed
the
cna_sv_selected_columns
branch
2 times, most recently
from
4dae5c8 to
a573f99
Compare
inodb
reviewed
Jan 30, 2023
Comment on lines
198
to
201
| # skin.results_view.mutation_table.columns.show_on_init= | ||
| # skin.patient_view.mutation_table.columns.show_on_init= | ||
| # skin.patient_view.copy_number_table.columns.show_on_init= | ||
| # skin.patient_view.structural_variant_table.columns.show_on_init= |
There was a problem hiding this comment.
Suggested change
| # skin.results_view.mutation_table.columns.show_on_init= | |
| # skin.patient_view.mutation_table.columns.show_on_init= | |
| # skin.patient_view.copy_number_table.columns.show_on_init= | |
| # skin.patient_view.structural_variant_table.columns.show_on_init= | |
| skin.results_view.mutation_table.columns.show_on_init= | |
| skin.patient_view.mutation_table.columns.show_on_init= | |
| skin.patient_view.copy_number_table.columns.show_on_init= | |
| skin.patient_view.structural_variant_table.columns.show_on_init= |
There was a problem hiding this comment.
@inodb Thanks for the suggestion. I've fixed the code and rebased the PR.
… variant tables on init
oplantalech
force-pushed
the
cna_sv_selected_columns
branch
from
a573f99 to
a8e944b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
dippindots
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #9912, this PR extends the functionality to the patient view tables of Copy Number and Structural Variant data (properties that will allow to define the columns that are shown on initialization for Copy Number and Structural Variant patient view tables).