Set the ServerName field in the ClientHelloInfo when it was unset and a default SNI name is configured

[ankon]

See discussion in slack: https://caddyserver.slack.com/archives/C4DMTEMGD/p1714689199952049

[ankon]

Related to: https://github.com/caddyserver/certmagic/tree/default-sni

[ArturFortunato]

The second validation is kinda redundant right? Worst case scenario you're just setting "" = ""

[mholt]

As discussed in Slack, this might be superseded by the default-sni branch in CertMagic which applies this a little more broadly at the cert-management layer.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ankon
❌ ArturFortunato
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[mholt]

If I understand correctly, the default-sni branch of CertMagic will supersede this, so I'll close this. (But correct me if I'm wrong and we can reopen it. 😃 )

[ankon]

Mostly for linking things up: The "default-sni branch" is caddyserver/certmagic#287, which is in certmagic and released with 0.21.1.