Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the ServerName field in the ClientHelloInfo when it was unset and a default SNI name is configured #6297

Closed
wants to merge 2 commits into from
Closed

Set the ServerName field in the ClientHelloInfo when it was unset and a default SNI name is configured #6297

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c1dec4
Set the `ServerName` field in the ClientHelloInfo when it was unset a…
ankon May 3, 2024
32c6511
Add logs to debug
ArturFortunato May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions modules/caddytls/connpolicy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,9 @@ func (p *ConnectionPolicy) buildStandardTLSConfig(ctx caddy.Context) error {
cfg.CertSelection = p.CertSelection
}
cfg.DefaultServerName = p.DefaultSNI
if hello.ServerName == "" && p.DefaultSNI != "" {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second validation is kinda redundant right? Worst case scenario you're just setting "" = ""

hello.ServerName = p.DefaultSNI
}
cfg.FallbackServerName = p.FallbackSNI
return cfg.GetCertificate(hello)
},
Expand Down
Loading