Fix backwards compatibility of CSTR #311
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #308
Before
_constSolidVolume
was always zero because the state ofinit_liquid_volume
was declared after the parameters.To fix this, there is now a variable
init_liquid_volume
to calculate_constSolidVolume
even if the state is not set.Additionally the calculation of
_constSolidVolume
has been fixed:Before we calculated
which is wrong because we distinguish between the total volume of the reaction$V^{total}$ and the volumes of the liquid and solid phases.
Instead we now calculate
For the last equation we used that$(1-\varepsilon) = \frac{V^{l}}{V^{l} + V^{s}} \Leftrightarrow \frac{V^{l}}{(1-\varepsilon)} - V^{l}$