-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not return coordinates for singleton dimensions #339
Conversation
Side-Note:
Shouldn't it already be 5.0.2? |
Good point! I had also noticed it but thought that maybe this was a local issue. Should have written it down somewhere... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running cadet-verification i saw that the crystllization tests are broken, chromatograohy tests still work. However that happened before the changes made on this PR.
Ill see if I can fix this and push the changes here to this branch since this should also be part of 5.0.3 :D
The version info is read from git as specified in the CADET-Verification works fine now |
yeah, if you run
it returns
not quite sure why, though... |
Is it worth looking deeper into this or should we just continue with v5.0.3, assuming that this is automatically fixed ? |
I assume it is connected to the complications of the last release. Since the ´cadet-cli´ of the actual release 5.0.2 shows the correct versions, personally I would just move on. |
let's move on. |
This commit fixes the calculation of constant solid volume from the old interface fields, which are supported for backwards compatibility.
d92db32
to
16203c3
Compare
Fixes #334
additionally, we fix the support of the old CSTR interface (fix of #311)
Checklist
Please ensure you've completed the following tasks. Mark them with an
x
inside the brackets:To do
isParticleLumped
cadet-cli --version
returns the wrong version number