-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add labels to DBT models #3675
Add labels to DBT models #3675
Conversation
transit_database: | ||
+labels: | ||
domain: intermediate | ||
dataset: transit_database | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Items inside mart:
(bellow) were not removed, just reordered alphabetically.
ad_hoc: | ||
schema: mart_ad_hoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ad-hoc
is the only item actually removed, since there is a warning alerting about it when executing poetry run dbt run
(see below) and there are no more tables on our codebase under this dataset. Looking through the logs, looks like it was just a testing dataset.
[WARNING]: Configuration paths exist in your dbt_project.yml file which do not apply to any resources.
There are 1 unused configuration paths:
- models.calitp_warehouse.mart.ad_hoc
Last model fct_scheduled_service_by_daypart removed March 2024 on PR #3298
b7eea38
to
30595dc
Compare
Description
This PR will add two labels to DBT models helping us to improve billing reports as part of the issue #3541.
Label were based on the current dataset structure.
domain:
dataset:
Type of change
How has this been tested?
Tested locally creating tables on staging.
Post-merge follow-ups
Check if all labels on BigQuery were created after next DAGs' run.