Add participating stores to Rewards screen #129
Conversation
There was a problem hiding this comment.
Looks great! I just noted a small change to improve accessibility with the buttons.
This led me to ask a few Quacetions so these designs may be subject to change (sorry), but either I or Ace will let you know if anything does need to be changed once those are addressed.
cc @12aschen
components/rewards/RewardsHome.js
Outdated
| style={{ marginLeft: 8 }} | ||
| key={store.id} | ||
| onPress={() => | ||
| navigation.navigate('Stores', { |
There was a problem hiding this comment.
Hmm this is really really slow to load for some reason. Could we do first do a navigation.goBack then do changeCurrentStore from MapScreen to set the store if that's not too clunky?
There was a problem hiding this comment.
Just so it doesn't leave the user staring at the screen wondering what's happening/what's supposed to happen.
Also, can you wrap these in touchable opacities so there's some response when these are clicked? Even that might help indicate that some action is supposed to happen bc rn it's quite ambiguous.
There was a problem hiding this comment.
Could we do first do a navigation.goBack then do changeCurrentStore from MapScreen to set the store if that's not too clunky?
AFAIK this isn't possible? The method that gets invoked is componentWillReceiveProps, which is setting the store in MapScreen. Also it wasn't slow for me on simulator :o
can you wrap these in touchable opacities so there's some response when these are clicked
👍
|
Updated styling + added to guest mode |
| <TouchableOpacity key={store.id}> | ||
| <Subhead | ||
| style={{ marginLeft: 12 }} | ||
| onPress={() => |
There was a problem hiding this comment.
When I click this, it doesn't show the map marker as selected.
What's new in this PR
StoreListScreendoes)Unrelated fixes
rewardPointValueandrewardDollarValuefrom/constantsfor the cards from Additional reward cards for point history #93keyfor those lists (would happen rarely in PROD assuming customers have small total purchase amounts in $)devmode (necessary to test this feature since you need to be able to see rewards)StoreDetailsLOLRelevant Links
Online sources
We should fix this error probably? "never" is a scary word 🤷♀️ (lol)
https://www.lahteenlahti.com/fixing-virtualizedlists-should-never-be-nested-inside-plain-scrollviews/
Related PRs
branches off #128
update #93
How to review
Styling
Not sure if spacing still needs to be adjusted, especially the indent.
Functionality
Log in, make sure nothing breaks, and that stores redirect correctly.
Try updating the
rewards acceptedvalue in the [DEV] Airtable (but remember to switch it back after, please)If erroneous lint/prop-types errors show up, please review #128
Next steps
N/A
Tests Performed, Edge Cases
rewardsUnlockedorrewardsAppliedvalue (or whichever) theArray(rewardsUnlocked)...throws an error like 'Array size too big', probably because the value is undefinedScreenshots
https://www.loom.com/share/8f9166e49f9544edae54188634e6bd53
CC: @wangannie