Additional reward cards for point history #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangannie
requested changes
Apr 16, 2020
| </Caption> | ||
| <Subhead>{`${pointsEarned} points earned`}</Subhead> | ||
| <Caption color={Colors.secondaryText}> | ||
| {`for ${displayDollarValue(totalSale || 0)} of healthy products`} |
There was a problem hiding this comment.
I know it was like this before but would this make more sense to be subtotal?
There was a problem hiding this comment.
Oh nevermind I guess it makes sense that the number of points directly corresponds to the total sale (bc the rewards points are deducted?) but this language might not fit since they did actually pay more for the total healthy products...if that makes sense
cc @12aschen ?
There was a problem hiding this comment.
It's probably easiest to match what we do in Clerk (which I cannot currently recall) but I would guess this is a quacetion that we can defer. Just don't forget to check in on it 😅
annieyro
approved these changes
Apr 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Relevant Links
Related PRs
How to review
Next steps
Tests Performed, Edge Cases
Screenshots
CC: @anniero98 @wangannie